feat!: rewrite to TS and adjust to the v2 ParserJS #142

magicmatatjahu · 2022-10-19T12:40:40Z

Description

Rewrite to TS.
Adjust exported module to the new v2 ParserJS Custom Schema Parser interface - new validate() function.
Improve testing and move to the Jest.
Update Readme.
Add @magicmatatjahu to the codeowners.

Related issue(s)
Resolves #140

smoya · 2022-10-20T07:51:24Z

src/index.ts

+  return result;
+}
+
+async function parse(input: ParseSchemaInput<unknown, unknown>): Promise<v2.SchemaObject> {


Suggested change

async function parse(input: ParseSchemaInput<unknown, unknown>): Promise<v2.SchemaObject> {

async function parse(input: ParseSchemaInput<unknown, unknown>): Promise<AsyncAPISchema> {

I know it perfectly well 😂 I wait for your PR.

self service! asyncapi/parser-js#656 :D

smoya · 2022-10-20T07:51:36Z

src/index.ts

+// eslint-disable-next-line @typescript-eslint/no-var-requires
+const toJsonSchema = require('@openapi-contrib/openapi-schema-to-json-schema');
+
+import type { SchemaParser, ValidateSchemaInput, ParseSchemaInput, SchemaValidateResult } from '@asyncapi/parser';


Suggested change

import type { SchemaParser, ValidateSchemaInput, ParseSchemaInput, SchemaValidateResult } from '@asyncapi/parser';

import type { SchemaParser, ValidateSchemaInput, ParseSchemaInput, SchemaValidateResult, AsyncAPISchema } from '@asyncapi/parser';

smoya · 2022-10-20T07:52:42Z

src/index.ts

+const toJsonSchema = require('@openapi-contrib/openapi-schema-to-json-schema');
+
+import type { SchemaParser, ValidateSchemaInput, ParseSchemaInput, SchemaValidateResult } from '@asyncapi/parser';
+import type { v2 } from '@asyncapi/parser/esm/spec-types';


Suggested change

import type { v2 } from '@asyncapi/parser/esm/spec-types';

smoya · 2022-10-20T08:28:15Z

@magicmatatjahu I think using next-major as target branch its a better approach, so this can be merged and released as beta first.

magicmatatjahu · 2022-11-08T10:10:47Z

@smoya Yeah, we can, but we need branches.

@derberg @fmvilas Could you create next-major branch? I need it for releasing new major version of parser with v2 ParserJS support.

smoya · 2022-11-08T10:11:34Z

@fmvilas @derberg as code owners, would you mind doing a review to this? Thanks!

fmvilas

LGTM in general. Just added a comment.

CODEOWNERS

sonarqubecloud · 2022-11-14T06:53:41Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

derberg · 2022-11-14T10:13:13Z

I have same question as asyncapi/avro-schema-parser#168 (review), but this PR is a bit different and points to master directly. Should we really release it as major and automatically bump it in generator?

magicmatatjahu · 2022-11-14T10:24:45Z

@derberg

Should we really release it as major and automatically bump it in generator?

We will but it doesn't work with parser in generator. In this PR I made integration asyncapi/generator#833 but I'm fighting with snapshots 😆

but this PR is a bit different and points to master directly.

Yeah, because I don't have next-major branch in this repo, cc @fmvilas

github-actions · 2023-03-15T00:04:28Z

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

smoya · 2023-03-15T09:11:53Z

relevant

smoya · 2023-03-15T09:34:30Z

@fmvilas @derberg can any of you create the next-major branch? I want to move forward with this PR. Once is done, @magicmatatjahu would u mind changing the base branch and update it?

Thanks

smoya · 2023-03-30T11:34:18Z

package.json

  "dependencies": {
-    "@openapi-contrib/openapi-schema-to-json-schema": "^3.0.0"
+    "@asyncapi/parser": "^2.0.0-next-major.8",
+    "@openapi-contrib/openapi-schema-to-json-schema": "^3.2.0",


This should be pinned to ~3.2.0. See asyncapi/generator#927

I tried to do the change but I have no permission on your branch @magicmatatjahu

smoya

See https://github.com/asyncapi/openapi-schema-parser/pull/142/files#r1153125770

Co-authored-by: Fran Méndez <[email protected]>

smoya · 2023-04-11T09:15:22Z

@fmvilas @derberg please approve when you have a chance. Last change was just the fix on dependencies

sonarqubecloud · 2023-04-28T04:45:25Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

smoya · 2023-04-28T13:18:11Z

/rtm

Co-authored-by: Sergio Moya <[email protected]>

asyncapi-bot · 2023-04-28T13:56:31Z

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

magicmatatjahu requested review from fmvilas, derberg and asyncapi-bot-eve as code owners October 19, 2022 12:40

smoya reviewed Oct 20, 2022

View reviewed changes

magicmatatjahu force-pushed the rewrite-to-ts branch from 43c1044 to 9eb252c Compare November 2, 2022 13:43

fmvilas requested changes Nov 14, 2022

View reviewed changes

CODEOWNERS Outdated Show resolved Hide resolved

fmvilas previously approved these changes Nov 14, 2022

View reviewed changes

github-actions bot added the stale label Mar 15, 2023

github-actions bot removed the stale label Mar 16, 2023

smoya reviewed Mar 30, 2023

View reviewed changes

smoya requested changes Mar 30, 2023

View reviewed changes

smoya mentioned this pull request Mar 30, 2023

fix: pin @openapi-contrib/openapi-schema-to-json-schema to ~3.2.0 asyncapi/parser-js#741

Merged

magicmatatjahu added 7 commits April 2, 2023 16:02

feat: rewrite to TS and adjust to the v2 ParserJS

897a90a

update Readme

90f0dd4

fix typo

b39f5b9

fix typo

f2cb334

update deps

183f933

bump deps

21c44de

add branches

c6ca7ff

magicmatatjahu and others added 3 commits April 2, 2023 16:02

update deps

bf065db

update branches

6bc3e94

Update CODEOWNERS

b8d3894

Co-authored-by: Fran Méndez <[email protected]>

magicmatatjahu dismissed fmvilas’s stale review via b8d3894 April 2, 2023 14:02

magicmatatjahu force-pushed the rewrite-to-ts branch from 59c5c05 to b8d3894 Compare April 2, 2023 14:02

fix openapi deps

b7e7ed6

smoya approved these changes Apr 11, 2023

View reviewed changes

smoya mentioned this pull request Apr 23, 2023

feat!: remove schema parsers from this repository asyncapi/parser-js#756

Merged

Merge branch 'master' into rewrite-to-ts

7e76cef

smoya approved these changes Apr 24, 2023

View reviewed changes

smoya mentioned this pull request Apr 24, 2023

chore: add @smoya as code owner #179

Merged

smoya added 2 commits April 25, 2023 12:00

Merge branch 'master' into rewrite-to-ts

05e3b7a

Merge branch 'master' into rewrite-to-ts

7defe10

asyncapi-bot added the ready-to-merge label Apr 28, 2023

asyncapi-bot merged commit 2056509 into asyncapi:master Apr 28, 2023

smoya added a commit to smoya/openapi-schema-parser that referenced this pull request Apr 28, 2023

feat!: rewrite to TS and adjust to the v2 ParserJS (asyncapi#142)

0818e59

Co-authored-by: Sergio Moya <[email protected]>

asyncapi-bot pushed a commit that referenced this pull request Apr 28, 2023

feat!: rewrite to TS and adjust to the v2 ParserJS (#142) (#185)

8622eb6

asyncapi-bot added the released label Apr 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: rewrite to TS and adjust to the v2 ParserJS #142

feat!: rewrite to TS and adjust to the v2 ParserJS #142

magicmatatjahu commented Oct 19, 2022

smoya Oct 20, 2022

magicmatatjahu Oct 20, 2022

smoya Oct 20, 2022

smoya Oct 20, 2022

smoya Oct 20, 2022

smoya commented Oct 20, 2022

magicmatatjahu commented Nov 8, 2022

smoya commented Nov 8, 2022

fmvilas left a comment

sonarqubecloud bot commented Nov 14, 2022

derberg commented Nov 14, 2022

magicmatatjahu commented Nov 14, 2022 •

edited

Loading

github-actions bot commented Mar 15, 2023

smoya commented Mar 15, 2023

smoya commented Mar 15, 2023

smoya Mar 30, 2023

smoya Mar 30, 2023

smoya left a comment

smoya commented Apr 11, 2023

sonarqubecloud bot commented Apr 28, 2023

smoya commented Apr 28, 2023

asyncapi-bot commented Apr 28, 2023

	async function parse(input: ParseSchemaInput<unknown, unknown>): Promise<v2.SchemaObject> {
	async function parse(input: ParseSchemaInput<unknown, unknown>): Promise<AsyncAPISchema> {

	import type { SchemaParser, ValidateSchemaInput, ParseSchemaInput, SchemaValidateResult } from '@asyncapi/parser';
	import type { SchemaParser, ValidateSchemaInput, ParseSchemaInput, SchemaValidateResult, AsyncAPISchema } from '@asyncapi/parser';

feat!: rewrite to TS and adjust to the v2 ParserJS #142

feat!: rewrite to TS and adjust to the v2 ParserJS #142

Conversation

magicmatatjahu commented Oct 19, 2022

smoya Oct 20, 2022

Choose a reason for hiding this comment

magicmatatjahu Oct 20, 2022

Choose a reason for hiding this comment

smoya Oct 20, 2022

Choose a reason for hiding this comment

smoya Oct 20, 2022

Choose a reason for hiding this comment

smoya Oct 20, 2022

Choose a reason for hiding this comment

smoya commented Oct 20, 2022

magicmatatjahu commented Nov 8, 2022

smoya commented Nov 8, 2022

fmvilas left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 14, 2022

derberg commented Nov 14, 2022

magicmatatjahu commented Nov 14, 2022 • edited Loading

github-actions bot commented Mar 15, 2023

smoya commented Mar 15, 2023

smoya commented Mar 15, 2023

smoya Mar 30, 2023

Choose a reason for hiding this comment

smoya Mar 30, 2023

Choose a reason for hiding this comment

smoya left a comment

Choose a reason for hiding this comment

smoya commented Apr 11, 2023

sonarqubecloud bot commented Apr 28, 2023

smoya commented Apr 28, 2023

asyncapi-bot commented Apr 28, 2023

magicmatatjahu commented Nov 14, 2022 •

edited

Loading